-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changing detect stop works when handle a tab click event. #9811
Comments
Spook too soon. Looks like you're right. Thanks for the heads up |
This looks like a duplicate of #9392. I am affected by the same issue. |
I believe so - if so, then @manucorporat has fixed it I believe - see: #9512 (but the rc.5 milestone was removed from #9392, so I do not know if it is destined for rc.5 or not). |
Pulling down #9512 locally and applying it to my test seem to fix things! |
The current selected tab should NOT be deselected (i.e. detached from change detection) if the selected tab does not have a root ie. a tab that acts as a button to open a modal, logout etc. Lifecycle events should not be dispatched either. Right now we are dispatching willLeave/willEnter always (this is a bug). Closes #9392. Closes #9811. Closes #9392.
So, where can I get this fix? |
We'll cut a nightly release with this soon. It will be officially available in the next release
… On Jan 6, 2017, at 8:11 PM, netsesame ***@***.***> wrote:
So, where can I get this fix?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub, or mute the thread.
|
This will be in the next release, if you'd like to test it sooner please install the latest nightly:
Let us know if you see any problems. Thanks! |
The nightly version fix it perfectly. Thanks a lot. |
Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out. |
Ionic version: (check one with "x")
[ ] 1.x
[x] 2.x
I'm submitting a ... (check one with "x")
[x] bug report
[ ] feature request
[ ] support request => Please do not submit support requests here, use one of these channels: https://forum.ionicframework.com/ or http://ionicworldwide.herokuapp.com/
Your system information:
ordova CLI: 6.4.0
Ionic Framework Version: 2.0.0-rc.4
Ionic CLI Version: 2.1.18
Ionic App Lib Version: 2.1.9
Ionic App Scripts Version: 0.0.47
ios-deploy version: Not installed
ios-sim version: Not installed
OS: Windows 10
Node Version: v4.3.1
Xcode version: Not installed
Current behavior:
In an ionic's tabs based app, if we handle a button click from a tab button, change some states, ionic's changing detecting mechanism for the current page will stop working. Only thing we can do is exist and re-enter the view.
Expected behavior:
We hope it will be that, by clicking a tab button, change some states, the states will be updated in the binding views.
Steps to reproduce:
The text was updated successfully, but these errors were encountered: