Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Comments within objects are not resolved correctly - Angular Build not possible. #483

Open
3 tasks done
marcomattes opened this issue Sep 17, 2024 · 2 comments
Open
3 tasks done
Labels
help wanted a good issue for the community package: angular @stencil/angular-output-target package type: bug Something isn't working

Comments

@marcomattes
Copy link

marcomattes commented Sep 17, 2024

Prerequisites

Stencil Version

4.21.0

Stencil Framework Output Target

Angular

Stencil Framework Output Target Version

0.9.0

Current Behavior

If I add a comment within an event type, this is built inline in the build and breaks the components.d.ts file.
Angular can then no longer be built.

Input

  @Event({
    eventName: 'someTestEvent',
  })
  formValidationEvent!: EventEmitter<{
    field;
    field2;
    // someCommentLikeTsIgnoreOrElse
    errorField: {};
  }>;

Output

export declare interface MyComponent extends Components.MyComponent {

  someTestEvent: EventEmitter<CustomEvent<{ field; field2; // someCommentLikeTsIgnoreOrElse errorField: {}; }>>;
}

Expected Behavior

Comments should be removed or made safe (new line or similar)

Steps to Reproduce

Open: https://stackblitz.com/edit/stencil-template-aiden-c7padq?file=angular-workspace%2Fprojects%2Fcomponent-library%2Fsrc%2Flib%2Fstencil-generated%2Fcomponents.ts

Run: npm run build

Code Reproduction URL

https://stackblitz.com/edit/stencil-template-aiden-c7padq?file=angular-workspace%2Fprojects%2Fcomponent-library%2Fsrc%2Flib%2Fstencil-generated%2Fcomponents.ts

Additional Information

No response

@ionitron-bot ionitron-bot bot added the triage label Sep 17, 2024
Copy link

ionitron-bot bot commented Sep 17, 2024

Thanks for the issue!

This project is currently maintained for the purposes of supporting Ionic Framework. At this time, only new issues & pull requests that support Ionic Framework will be prioritized. For the latest updates regarding the maintenance status of this project, please see this section of the project's README

@christian-bromann christian-bromann added type: bug Something isn't working package: angular @stencil/angular-output-target package help wanted a good issue for the community and removed triage labels Oct 14, 2024
Copy link

ionitron-bot bot commented Oct 14, 2024

This issue has been labeled as help wanted. This label is added to issues that we believe would be good for contributors.

If you'd like to work on this issue, please comment here letting us know that you would like to submit a pull request for it. This helps us to keep track of the pull request and make sure there isn't duplicated effort.
Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted a good issue for the community package: angular @stencil/angular-output-target package type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants