Skip to content
This repository has been archived by the owner on Jan 27, 2021. It is now read-only.

type declaration is necessary for typescript user #263

Closed
chuyuandu opened this issue May 12, 2020 · 2 comments
Closed

type declaration is necessary for typescript user #263

chuyuandu opened this issue May 12, 2020 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@chuyuandu
Copy link

feature request

there's no declaration file in the package
it will raise an eslint error in default CRA project
type declaration is necessary for users
@mpeyper
Copy link
Contributor

mpeyper commented May 12, 2020

This package does a lot of crazy dynamic things that are difficult to statically type (or at least beyond my Typescript abilities).

If anyone want to take this on, I'd gladly accept a PR to add type definitions.

@mpeyper mpeyper added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels May 12, 2020
@mpeyper
Copy link
Contributor

mpeyper commented Jan 27, 2021

Closing. Please see #484 for details.

@mpeyper mpeyper closed this as completed Jan 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@chuyuandu @mpeyper