Skip to content
This repository has been archived by the owner on Apr 11, 2019. It is now read-only.

Merge outstanding pull requests #198

Closed
dpsnowden opened this issue Nov 18, 2014 · 5 comments
Closed

Merge outstanding pull requests #198

dpsnowden opened this issue Nov 18, 2014 · 5 comments

Comments

@dpsnowden
Copy link
Contributor

All, there are 7 outstanding pull requests. Can you please decide a way to divide the work and get these new results merged? We're trying to write up some results and need to be able to see the latest and greatest. It looks like many of the PRs fail the travis-ci checks so I'm not sure what is involved.

@Bobfrat @birdage @kwilcox @kknee @ocefpaf @wckoeppen

Anyone?....Bueller?

@ocefpaf
Copy link
Member

ocefpaf commented Nov 18, 2014

There are 3 tests in the current travis-ci setup that breaks down as:

  • test_environments.py Just a place holder this test is not implemented.
  • test_notebooks.py Will probably fails 99.99% of the time since it runs all notebooks. The failures range from timeouts to missing/bad files and/or URLs.
  • test_system-test_rules.py Maybe the only test that we should pay attention. Checks for the existence of corresponding .py files, pip-requirements.txt and conda-requirements.txt.

The PR #199 runs only test_system-test_rules.py, that way the travis output has some meaning and might help review the pending PRs. Here is an example of the output (go straight to the end of the file)

The outstanding PRs are:

@birdage
Copy link
Contributor

birdage commented Nov 19, 2014

ill look at #177 today

@jkupiec
Copy link

jkupiec commented Dec 1, 2014

We are now down to 3 open pull requests. Can anyone provide some resolution?

@kknee
Copy link

kknee commented Dec 1, 2014

@birdage and @ocefpaf are actively working on #177, looks like we're waiting for @rsignell-usgs to comment on #173.

@ocefpaf
Copy link
Member

ocefpaf commented Nov 10, 2015

There are no outstanding PR. (I closed #173 today.)

@ocefpaf ocefpaf closed this as completed Nov 10, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants