Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task] Update the resolution example to use the new Resolver #835

Closed
8 tasks
olivereanderson opened this issue May 5, 2022 · 1 comment
Closed
8 tasks
Assignees
Labels
Rust Related to the core Rust code. Becomes part of the Rust changelog. Wasm Related to Wasm bindings. Becomes part of the Wasm changelog

Comments

@olivereanderson
Copy link
Contributor

olivereanderson commented May 5, 2022

Description

Update the Resolution examples examples/low_level/resolution to use the new Resolver instead of the now deprecated spec compliant resolution API.

Motivation

The examples should not encourage using deprecated methods and this particular case the update was requested by @JelleMillenaar in his review of #823.

Resources

#823 is blocked by this task.

To-do list

Create a task-specific to-do list . Please link PRs that match the To-do list item behind the item after it has been submitted.

  • Update the example for the Rust library
  • Update the example for the Wasm library

Change checklist

Add an x to the boxes that are relevant to your changes, and delete any items that are not.

  • The feature or fix is implemented in Rust and across all bindings whereas possible.
  • The feature or fix has sufficient testing coverage
  • All tests and examples build and run locally as expected
  • Every piece of code has been document according to the documentation guidelines.
  • If conceptual documentation (mdbook) and examples highlighting the feature exist, they are properly updated.
  • If the feature is not currently documented, a documentation task Issue has been opened to address this.
@olivereanderson olivereanderson self-assigned this May 5, 2022
@olivereanderson olivereanderson added Rust Related to the core Rust code. Becomes part of the Rust changelog. Wasm Related to Wasm bindings. Becomes part of the Wasm changelog labels May 5, 2022
@olivereanderson olivereanderson added this to the Documentation catch-up milestone May 5, 2022
@olivereanderson olivereanderson changed the title [Task] Update the resolution examples to use the new Resolver [Task] Update the resolution example to use the new Resolver May 5, 2022
@olivereanderson
Copy link
Contributor Author

Closed by #838

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Rust Related to the core Rust code. Becomes part of the Rust changelog. Wasm Related to Wasm bindings. Becomes part of the Wasm changelog
Projects
None yet
Development

No branches or pull requests

1 participant