Skip to content
This repository has been archived by the owner on Aug 23, 2020. It is now read-only.

The current xxHash implementation hashes the whole packet #1438

Closed
jakubcech opened this issue May 7, 2019 · 0 comments
Closed

The current xxHash implementation hashes the whole packet #1438

jakubcech opened this issue May 7, 2019 · 0 comments
Assignees
Labels
C-Network E-Performance Epic - Improving throughput of IRI T-Bug
Milestone

Comments

@jakubcech
Copy link
Contributor

jakubcech commented May 7, 2019

Description

The change introduced in #1326 hashes not only the transaction trytes, but also additional packet info like the request bytes. This needs to be changed back so that only the tx trytes are in the digest.

Motivation

The current implementation is incorrect and creates a lot of misses on the cache.

Whole packet hash:

long digest = getBytesDigest(receivedData);

Only TX hash:

long digest = getBytesDigest(transactionViewModel.getBytes());

@jakubcech jakubcech added C-Network E-Performance Epic - Improving throughput of IRI T-Bug L-Groom This issue needs to be groomed and removed L-Groom This issue needs to be groomed labels May 7, 2019
@jakubcech jakubcech added this to the Caeseria milestone May 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
C-Network E-Performance Epic - Improving throughput of IRI T-Bug
Projects
None yet
Development

No branches or pull requests

2 participants