Skip to content
This repository has been archived by the owner on Aug 23, 2020. It is now read-only.

Test ZMQ topics #1598

Open
GalRogozinski opened this issue Sep 4, 2019 · 3 comments · May be fixed by #1730
Open

Test ZMQ topics #1598

GalRogozinski opened this issue Sep 4, 2019 · 3 comments · May be fixed by #1730

Comments

@GalRogozinski
Copy link
Contributor

Description

For each zmq topic we should have a regression test that ascertains it continues to work

Motivation

So we don't accidentally remove zmq topics

Issues / Scenarios

See each topic in https://github.com/iotaledger/iri/blob/dev/src/main/java/com/iota/iri/zmq/README.md

How to test for this

We can hook into already existing tests and just add the necessary steps.
Since spinning up a cluster takes time, we don't want to make the regression tests take much longer time.

@DyrellC
Copy link
Contributor

DyrellC commented Jan 27, 2020

I'm going to compile a quick list of zmq topics and where would be the most appropriate place for those tests to be integrated machine wise. I'll ping you @GalRogozinski when I've figured out where I plan to put them

@DyrellC
Copy link
Contributor

DyrellC commented Jan 27, 2020

  • mctn - Number of transactions walked - GTTA - machine 1
  • lmi - Latest Milestone Index - Milestone test - machine 6
  • lmsi - Latest Milestone Solid Index - Milestone test - machine 6
  • lmhs - Latest solid milestone hash - Milestone test - machine 6
  • sn - Solidified transaction - transaction tests - machine 2
  • sn_trytes - solidified transaction trytes - transaction tests - machine 2
  • tx - New transaction - transaction tests - machine 2
  • tx_trytes - new transaction trytes - transaction tests - machine 2

@GalRogozinski

@DyrellC DyrellC linked a pull request Jan 27, 2020 that will close this issue
4 tasks
@GalRogozinski
Copy link
Contributor Author

You are just missing the <Address> topic. See ZMQ README and

tangle.publish("%s %s %d sn", transaction.getAddressHash(), transaction.getHash(), index);

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants