Skip to content
This repository has been archived by the owner on Aug 23, 2020. It is now read-only.

Add Milestone Request to message protocol #1793

Open
kwek20 opened this issue Mar 13, 2020 · 0 comments · May be fixed by #1829
Open

Add Milestone Request to message protocol #1793

kwek20 opened this issue Mar 13, 2020 · 0 comments · May be fixed by #1829
Assignees
@acha-bill
Milestone
Mardi Gras

Comments

@kwek20
Copy link
Contributor

kwek20 commented Mar 13, 2020 •
edited
Loading

Description

Requests a range of milestones by index. Expects to receive in response the milestone bundle for the specified index.

Motivation

Requesting milestones specifically will allow speed-up of syncing as we can do this in parallel instead of waiting until we find a new milestone by traversing down

Requirements

  1. Add a new message type named MS_REQUEST in ProtocolMessage
  2. Update MessageReader to read this message
  3. Update NeighborImpl to handle the message

According to the following details: https://github.com/iotaledger/protocol-rfcs/blob/d16a3815271cdb4b53ff3c234ea706bf764e1847/text/0001-protocol-messages/0001-protocol-messages.md#milestone-request
@kwek20 kwek20 changed the title Feature: add Milestone Request to message protocol Add Milestone Request to message protocol Mar 13, 2020
@kwek20 kwek20 mentioned this issue Mar 16, 2020
Open
@GalRogozinski GalRogozinski added L-Groom This issue needs to be groomed and removed L-Groom This issue needs to be groomed labels Mar 26, 2020
@GalRogozinski GalRogozinski added this to the Mardi Gras milestone Mar 30, 2020
@acha-bill acha-bill self-assigned this Apr 6, 2020
@acha-bill acha-bill linked a pull request Apr 7, 2020 that will close this issue
Open
5 tasks
@acha-bill acha-bill mentioned this issue May 18, 2020
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@acha-bill acha-bill

Labels
None yet
Projects
None yet
Milestone
Mardi Gras
Development

Successfully merging a pull request may close this issue.

adds milestone request to message protocol acha-bill/iri
3 participants
@kwek20 @GalRogozinski @acha-bill