-
Notifications
You must be signed in to change notification settings - Fork 298
Migrate to pull-streams #367
Comments
This has to go through a interface-ipfs-core proposal first |
Only the external api changes, not the internal refactor. |
external refactor? the http libraries are regular Streams base, adding pull-streams to internals would mean a double wrap |
Yes, but it's not clear if we should continue using them. |
@dignifiedquire I'm not sure if I understand what you have in mind, since adding pull-streams to internals would mean that we need to wrap the http request in a pull-streams based, is that what you propose? If so, my question is: Do we really need to do that? What is the need? |
Given the current libraries we use this probably doesn't make sense, unless we expose pull-streams on the interface level. Going to close this for now. |
Ref ipfs/js-ipfs#403
The text was updated successfully, but these errors were encountered: