Skip to content
This repository has been archived by the owner on Mar 10, 2020. It is now read-only.

Migrate to pull-streams #367

Closed
dignifiedquire opened this issue Sep 5, 2016 · 6 comments
Closed

Migrate to pull-streams #367

dignifiedquire opened this issue Sep 5, 2016 · 6 comments

Comments

@dignifiedquire
Copy link
Contributor

Ref ipfs/js-ipfs#403

  • Expose both pull and node-stream interface
  • Use pull-streams for all internals
@daviddias
Copy link
Contributor

This has to go through a interface-ipfs-core proposal first

@dignifiedquire
Copy link
Contributor Author

This has to go through a interface-ipfs-core proposal first

Only the external api changes, not the internal refactor.

@daviddias
Copy link
Contributor

external refactor? the http libraries are regular Streams base, adding pull-streams to internals would mean a double wrap

@dignifiedquire
Copy link
Contributor Author

http libraries are regular Streams base

Yes, but it's not clear if we should continue using them.

@daviddias
Copy link
Contributor

@dignifiedquire I'm not sure if I understand what you have in mind, since adding pull-streams to internals would mean that we need to wrap the http request in a pull-streams based, is that what you propose? If so, my question is: Do we really need to do that? What is the need?

@dignifiedquire
Copy link
Contributor Author

Given the current libraries we use this probably doesn't make sense, unless we expose pull-streams on the interface level. Going to close this for now.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants