Skip to content
This repository has been archived by the owner on Apr 29, 2020. It is now read-only.

Add an initial test #70

Open
RichardLitt opened this issue Jul 6, 2016 · 7 comments
Open

Add an initial test #70

RichardLitt opened this issue Jul 6, 2016 · 7 comments

Comments

@RichardLitt
Copy link
Collaborator

See if you can check if GitHub is down, for instance, to make #40 happen.

@harlantwood
Copy link
Collaborator

Go tests!

@RichardLitt
Copy link
Collaborator Author

@dignifiedquire You have a lot of experience in testing. Could you perhaps help me out here? I'm not sure where to start. Any reading material would be ace.

@dignifiedquire
Copy link

@RichardLitt what kind of tests exactly are you looking for?

@RichardLitt
Copy link
Collaborator Author

Any, in general. I know that testing is important; at the moment, the code for this project doesn't have any tests, and it is brittle. I keep coming against edge cases here and there, which throw off the final product.

One thing to do would be to modularize - for instance, take out the badge checking algorithm - and add tests with all sorts of edge cases for the badges - and then run them so that we know what will throw an error and what won't. That's something I can do. Thanks for helping me clarify that.

Will ping back if I need help.

@RichardLitt RichardLitt self-assigned this Aug 1, 2016
@dignifiedquire
Copy link

@RichardLitt happy to have a general hangout about things if you want to :)

@harlantwood
Copy link
Collaborator

began work on testing branch. not working as yet, need to pull it apart a bit more. WIP here: https://github.com/ipfs/project-repos/tree/chore/test

@harlantwood
Copy link
Collaborator

My plan is to refactor into a few classes, which can be tested separately. Likely:

  • Repo which wraps the octokat repo and adds methods
  • RepoMatrix which makes a table from Repos
  • App which adds the waiting spinner, jquery datatable, etc

@RichardLitt RichardLitt removed their assignment Aug 10, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants