Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small arrow icons don't respect CSS fill changes #42

Closed
jessicaschilling opened this issue Jun 18, 2020 · 1 comment
Closed

Small arrow icons don't respect CSS fill changes #42

jessicaschilling opened this issue Jun 18, 2020 · 1 comment
Assignees
@jessicaschilling @rafaelramalho19
Labels
dif/trivial Can be confidently tackled by newcomers effort/hours Estimated to take one or several hours good first issue Good issue for new contributors help wanted Seeking public contribution on this issue kind/bug A bug in existing code (including security flaws) P2 Medium: Good to have, but can wait until someone steps up status/ready Ready to be worked topic/design-front-end Front-end implementation of UX/UI work

Comments

@jessicaschilling
Copy link
Contributor

See https://dl.dropboxusercontent.com/s/4se8lc2atpo36qf/cBPG7IhgSF.mp4 for an example of how this fails within Storybook for Web UI.

To do:

  • Fix the arrow SVG
  • Push as a minor update
@jessicaschilling jessicaschilling added the need/triage Needs initial labeling and prioritization label Jun 18, 2020
@jessicaschilling jessicaschilling added dif/trivial Can be confidently tackled by newcomers effort/hours Estimated to take one or several hours good first issue Good issue for new contributors help wanted Seeking public contribution on this issue kind/bug A bug in existing code (including security flaws) P2 Medium: Good to have, but can wait until someone steps up status/ready Ready to be worked topic/design-front-end Front-end implementation of UX/UI work and removed need/triage Needs initial labeling and prioritization labels Jun 18, 2020
@rafaelramalho19
Copy link

After creating https://ipfs-css-icons.netlify.app/?path=/story/icons--list&knob-Size=60&knob-Fill=rgba(55,26,199,1)&knob-Search=Small it seems that the problem is not in ipfs-css and it's in webui.

Moving this issue there.

@rafaelramalho19 rafaelramalho19 mentioned this issue Jun 26, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jessicaschilling jessicaschilling

@rafaelramalho19 rafaelramalho19

Labels
dif/trivial Can be confidently tackled by newcomers effort/hours Estimated to take one or several hours good first issue Good issue for new contributors help wanted Seeking public contribution on this issue kind/bug A bug in existing code (including security flaws) P2 Medium: Good to have, but can wait until someone steps up status/ready Ready to be worked topic/design-front-end Front-end implementation of UX/UI work
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jessicaschilling @rafaelramalho19