Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify icons for consistency #8

Closed
nothingismagick opened this issue Mar 30, 2018 · 5 comments
Closed

Modify icons for consistency #8

nothingismagick opened this issue Mar 30, 2018 · 5 comments
Assignees
@jessicaschilling
Labels
dif/easy Someone with a little familiarity can pick up effort/hours Estimated to take one or several hours good first issue Good issue for new contributors help wanted Seeking public contribution on this issue kind/bug A bug in existing code (including security flaws) P2 Medium: Good to have, but can wait until someone steps up status/ready Ready to be worked topic/design-visual Visual design ONLY, not part of a larger UX effort

Comments

@nothingismagick
Copy link
Contributor

One of these does not belong.

screen shot 2018-03-30 at 20 25 50

I propose thinning out the body of the links like this:
link_new
@nothingismagick
Copy link
Contributor Author

nothingismagick commented Mar 30, 2018 •
edited
Loading

It seems like it would be obvious to have the IPFS logo here too...

EDIT
I spoke too soon. It is here, but strangely called "CUBE"...

@nothingismagick
Copy link
Contributor Author

nothingismagick commented Mar 30, 2018 •
edited
Loading

And this is so obvious that it hurts.

ipfs-pin

@lidel
Copy link
Member

lidel commented Mar 30, 2018 •
edited
Loading

I think these suggestions should be moved to ipfs-inactive/ipfs-ui-style-guide#3.
@nothingismagick can you close this issue and add these comments there instead?

@nothingismagick
Copy link
Contributor Author

Funny you say that @lidel - I almost posted them there first, but then I found this repo and thought that it was actually more standardized, less like an experiment and looked like the right place to leave the commentary. I will, post these suggestions there too. However, as that repository references this one as the host of the icons, the css and the fonts I think it might be better to leave it in both places for the time being.

@jessicaschilling jessicaschilling changed the title ICONSET Modify icons for consistency Apr 7, 2020
@jessicaschilling jessicaschilling added dif/easy Someone with a little familiarity can pick up effort/hours Estimated to take one or several hours good first issue Good issue for new contributors help wanted Seeking public contribution on this issue kind/bug A bug in existing code (including security flaws) P2 Medium: Good to have, but can wait until someone steps up status/ready Ready to be worked topic/design-visual Visual design ONLY, not part of a larger UX effort labels Apr 7, 2020
@jessicaschilling jessicaschilling self-assigned this Apr 13, 2020
@jessicaschilling jessicaschilling mentioned this issue Apr 13, 2020
Merged
@jessicaschilling
Copy link
Contributor

Closed by #40.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jessicaschilling jessicaschilling

Labels
dif/easy Someone with a little familiarity can pick up effort/hours Estimated to take one or several hours good first issue Good issue for new contributors help wanted Seeking public contribution on this issue kind/bug A bug in existing code (including security flaws) P2 Medium: Good to have, but can wait until someone steps up status/ready Ready to be worked topic/design-visual Visual design ONLY, not part of a larger UX effort
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@lidel @jessicaschilling @nothingismagick