Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: unpin old code (keep latest N revisions) #131

Open
sixcorners opened this issue Jan 13, 2020 · 5 comments · May be fixed by #233
Open

Feature: unpin old code (keep latest N revisions) #131

sixcorners opened this issue Jan 13, 2020 · 5 comments · May be fixed by #233
Labels
effort/hours Estimated to take one or several hours help wanted Seeking public contribution on this issue kind/enhancement A net-new feature or improvement to an existing feature

Comments

@sixcorners
Copy link
Contributor

So uh... I've never really bought into the whole "permanent" web thing. I think it would be nice if I could have this unpin old deployments.

@RuiNtD
Copy link

RuiNtD commented Jun 8, 2021

Agreed. Especially when using a pinning service like pinata.cloud, I don't want to have to be charged for having multiple copies of my website pinned.

@hacdias hacdias added effort/hours Estimated to take one or several hours help wanted Seeking public contribution on this issue kind/enhancement A net-new feature or improvement to an existing feature labels Aug 11, 2021
@hacdias
Copy link
Member

hacdias commented Aug 11, 2021

This is definitely an interesting feature and could be implemented by simply looking at the previous DNSLink value and unpinning it in the service. Perhaps through a flag --unpin-old.

@hacdias hacdias changed the title unpin old code Feature: unpin old code Aug 11, 2021
@kespinola
Copy link

I'm interested in this feature as well. And am up to add it.

Some questions I have around it:

  • If the previous pin is removed and DNS is still populating will there be a chance for a service outage?
  • I imagine this needs to be rolled out to the 3 supported providers. Any way to rollout for one first? I'm working with cloudflare. I suppose can skip if the service doesn't respond to the additional methods to perform the unpin.

@RuiNtD
Copy link

RuiNtD commented Aug 18, 2021

I'm interested in this feature as well. And am up to add it.

Some questions I have around it:

  • If the previous pin is removed and DNS is still populating will there be a chance for a service outage?

  • I imagine this needs to be rolled out to the 3 supported providers. Any way to rollout for one first? I'm working with cloudflare. I suppose can skip if the service doesn't respond to the additional methods to perform the unpin.

  1. This wouldn't be implemented on DNS providers. This would be implemented on the pinning services (like Pinata).
  2. Whether or not this causes an outage really just depends on how long TTL is on the DNSLink record. However, users can prevent an outage from occurring by uploading to their preferred pinning service (like Pinata) and pinning with Infura (which is free to use). ipfs-deploy site -u pinata -p infura

@RuiNtD
Copy link

RuiNtD commented Aug 18, 2021

On a side note: I feel like it might be important to delete old pins before uploading the new pin. If done in the other order, it might be possible for users to hit a quota on some pinning services.

@hacdias hacdias changed the title Feature: unpin old code Feature: unpin old code (keep latest N revisions) Sep 1, 2021
@banciur banciur linked a pull request Apr 10, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort/hours Estimated to take one or several hours help wanted Seeking public contribution on this issue kind/enhancement A net-new feature or improvement to an existing feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants