-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WebUI Integration #25
Comments
That was the initial idea but then it evolved to provide only one hash with all the files, that can be generated using the
We should just redirect to
Yes, and sometimes it's so slow that it ends up being unusable. I was going to open an issue about that, but I'll expose that here. If you go to a share files download page, the request that list the files takes ages. Is there any way of solving that? Note that as it's the download page we don't want to force the user to have a daemon running. |
Awesome! 😄
Will take a look at routing after #26 then! 😄
See #26! |
I believe this is something that should be handled on the server side because this app is an SPA so it should work from any page at all. The server should make those redirects. |
Redirects mean custom server config, and it's no longer just a case of loading the app from ipfs. I think we should focus on making the app work well with hash routing. I don't love it, but that's just a deveoper url aesthetic issue, I don't think it's something that end users care about. If a user handcrafts an invalid URL, things won't work. There is an argument that ipfs should work towards a great dev experience for hosting static sites and single page apps... we could lobby for supporting things like "if a directory has a 404.html in it, then redirect sites to that, if it has a 200.html, then redirect all sub paths to that like https://surge.sh/help/adding-a-200-page-for-client-side-routing We could start that discussion by making an ipfs gateway proxy that does those things and figure out the edge cases, and see what people think. In the meantime we have just have to use hash routing as we don't get any fancy redirects from ipfs hosted sites. |
Some ideas:
|
Dear fellows of @ipfs-shipyard/gui!
I was taking a look at how to integrate this with WebUI. The initial idea was to provide a link to
share.ipfs.io/add/QmHash1/QmHash2
with the hashes of the files to add.Issues I found and other problems worth mentioning:
/add
url.share.ipfs.io/add
without any hash.share.ipfs.io
won't be able to connect via API if the user doesn't explicitly allow that URLwindow.ipfs
it can be slower because it will use public API instead of user's node.I'll work on the first issues. The other ones need more thought. Thoughts?
The text was updated successfully, but these errors were encountered: