-
Notifications
You must be signed in to change notification settings - Fork 489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: navigate files in the wild 🦌 #1027
Conversation
License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com>
License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com>
License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com>
License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com>
License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com>
License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com>
License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com>
License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com>
So, this PR is kind of working and here are some screenshots of what is is right now. For more background on this PR, please read #1025 first. So, right now, we can already navigate
We also have a top bar, like GitHub's (on the repository) with some statistics: right now we have the number of blocks (clicking leads to nowhere), the number of pins (clicking leads to I'm pinging you here, @ericronne, so you could give me feedback on this. What do you think we could do to make this look better? Would you change the navigation? If so, why and how? How'd you improve the top/stats bar? |
License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com>
License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com>
License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com>
License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com>
License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com>
License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com>
License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com>
License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com>
License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com>
License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com>
License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com>
License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com>
License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com>
License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com>
This is awesome @hacdias 🙌 Some thoughts about the UI: We should do some minor tweaks here, as it feels weird the pins and files being clickable, but not the blocks. Do you think it would help adding the "Pin" logo here to go along with the home? And then find a way to add the number of peers there too. Why the "...More"? Will it be a new feature? If not, we should just keep the Should we add the Pin/Unpin feature in the bottom bar? I feel the breadcrumbs are way to large, we should try to lower the font-size and/or the font-weight. Why not hide the CID below the breadcrumbs, and only show it on hover? |
Hey @fsdiogo! Thanks for the feedback!
I presume you meant pins. Yeah, I personally wouldn't mind. We could even drop the number of pins. But I believe there are a lot of people that like numbers. If we find a good way to have both, it'd perhaps be nice. /cc @olizilla @ericronne
The
Perhaps... yes! Do we have space for that?
I can try tomorrow. I agree with the font size reduction. I didn't want to remove/hide the CID, but if we reduce the font size I think we should so we're not giving it the same importance as the breadcrumbs themselves. 😃 /cc @ericronne @olizilla |
License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com>
Signed-off-by: Henrique Dias <hacdias@gmail.com>
|
License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com>
License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com>
License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com>
Ping @olizilla |
@olizilla @fsdiogo I'm merging this now (it's been exactly 3 months since this PR was opened!). The tests are passing and everything seems to be working well. Other changes can be done afterwards in smaller, separate PRs. I ask you all to try anything you think that should be tested to make sure if it's working correctly. If so, please let me know and I'll fix it! |
Requires: