Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

returns false for a valid ipfs url/path! #48

Open
xylanreeves opened this issue Feb 8, 2022 · 2 comments · May be fixed by #94
Open

returns false for a valid ipfs url/path! #48

xylanreeves opened this issue Feb 8, 2022 · 2 comments · May be fixed by #94

Comments

@xylanreeves
Copy link

isIPFS.urlOrPath("ipfs://bafybeihbsysdkemc3kyylegtfopkrcfiih4exnasoql2q36fb4zawlrwhy/volcano.json")

returns false when it is a valid ipfs url/path!
@TimDaub
Copy link

TimDaub commented Jun 16, 2022 •
edited
Loading

yeah I was wondering the same thing. I'm currently crawling Zora's NFT contracts and many image URIs are the IANA ipfs scheme ipfs:// and I can't find a good way of "just" downloading them by looking at the docs. Am I missing something?

Edit: Seems even zora isn't capable of doing this: https://github.com/ourzora/nft-hooks/blob/6f0b9635b196051a5ff1242ebbf8e1335a742f6c/src/fetcher/UriUtils.ts#L5

Edit2: Found ipfs at IANA: https://www.iana.org/assignments/uri-schemes/uri-schemes.xhtml

This was referenced Jun 16, 2022
Closed
Open
TimDaub added a commit to neume-network/is-ipfs that referenced this issue Sep 6, 2022
@TimDaub
Add failing tests for recongnizing ipfs:// URIs
a5d55d9 
- Fixes ipfs-shipyard#48
TimDaub added a commit to neume-network/is-ipfs that referenced this issue Sep 6, 2022
@TimDaub
Match ipfs://...
64332de 
- Fixes ipfs-shipyard#48
@TimDaub TimDaub mentioned this issue Sep 6, 2022
Closed
@NCGThompson
Copy link

I don't remember where, but I did read somewhere that ipfs:(without the //) and ipfs:/ should also be interpreted as ipfs urls. The same goes for ipns://.

In addition, dweb://ipfs/ and dweb://ipns/ (or something like them) are also ipfs urls.

@achingbrain achingbrain linked a pull request Feb 6, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@TimDaub @xylanreeves @NCGThompson