-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Unixfs implementations #224
Comments
2023-10-05 conversation:
|
@Jorropo something we'd very much like is a fast recursive So, my questions:
|
Dedicated unixfs implementations are often much more performant and efficient.
See for example two of mines:
ipfs add
implementation that exists)io.Reader
file with incremental verification and data streaming)I think it is more sustainable to maintain a handful of dedicated implementations that individually do one job well (something like feather and something that would maintain state to support unordered dags are really different).
Unified middle layer
The way I have been writing my implementations is by jugling bytes
unixfs.proto
anddag-pb.proto
by hand everywhere.This is kinda meh looking because of all the little details that have to be checked.
I really think we need some efficient middle layer that takes in
blocks.Block
parse them, do sanity checks and return some representation that looks like internal unixfs (so one node per block, and full support for all schenanigans you would want to do but with error checking):This would not includes helper functions for more advanced stuff like HAMT, chunking, ... we will most likely need thoses too but the goal here is to provide a thin wrapper around the protobuf that add the repetitive input validation.
Impls
List of implementations we need:
The goal is to incremental verify ordered
.car
files from saturn on the cheap resource wise. (and other ordered blocks sources)io.Reader
) incrementally (while streaming the result out).io.Reader
for reading from files without any background goroutine (efficiency)..WriteAt
to write blocks in any order as long as we receive roots before leaves (or cache leaves but then incremental verification is not possible)The text was updated successfully, but these errors were encountered: