Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kubo/Boxo: pre PR signal that a contributor needs to run "go mod tidy" #309

Open
BigLep opened this issue May 18, 2023 · 0 comments
Open

Kubo/Boxo: pre PR signal that a contributor needs to run "go mod tidy" #309

BigLep opened this issue May 18, 2023 · 0 comments

Comments

@BigLep
Copy link
Contributor

BigLep commented May 18, 2023

Done Criteria

Before a contributor makes a PR to Boxo or Kubo they should have indication if their PR will fail CI checks due to go mod tidy checks.

Why Important

  1. This trips up most new contributors to the codebase
  2. Maintainers end up copy/pasting messages like feat: add deduplication ratio to 'ipfs dag stat' kubo#9787 (comment)

Notes

  1. We're not going to run mutating code by default, but during the make/build process we can highlight the issue and point someone to the steps they need to take.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
No open projects
IPFS Shipyard Team
Status: 🥞 Todo
Milestone
No milestone
Development

No branches or pull requests
2 participants
@BigLep @Jorropo