Skip to content
This repository has been archived by the owner on Mar 22, 2022. It is now read-only.

Font source target is invalid #23

Closed
djdv opened this issue Mar 7, 2019 · 0 comments · Fixed by #29
Closed

Font source target is invalid #23

djdv opened this issue Mar 7, 2019 · 0 comments · Fixed by #29
Assignees
Labels
dif/easy Someone with a little familiarity can pick up effort/hours Estimated to take one or several hours good first issue Good issue for new contributors help wanted Seeking public contribution on this issue kind/bug A bug in existing code (including security flaws) P2 Medium: Good to have, but can wait until someone steps up status/ready Ready to be worked topic/design-front-end Front-end implementation of UX/UI work

Comments

@djdv
Copy link

djdv commented Mar 7, 2019

The embedded style references a handful of fonts via a relative and nonexistant path ../fonts/
For instance font-family:'Glyphicons Halflings';src:url(../fonts/glyphicons-halflings-regular.eot);
This specifically causes issues when doing something like wget -r http://gateway/ipfs/Qm... presenting a bunch of 404's up front.

I'm not familiar enough with CSS to know, but is there any analog to the HTML <base> tag?
Specifically, I'm wondering if there's a way to hash these fonts and make the source target relative to the gateway root.
i.e. src:url(${gatewayroot}/ipfs/Qm.../font.eot)

If not, I suppose it would be best to just remove them.

@jessicaschilling jessicaschilling added dif/easy Someone with a little familiarity can pick up effort/days Estimated to take multiple days, but less than a week kind/bug A bug in existing code (including security flaws) P2 Medium: Good to have, but can wait until someone steps up status/ready Ready to be worked topic/design-front-end Front-end implementation of UX/UI work labels Apr 2, 2020
@jessicaschilling jessicaschilling changed the title font source target is invalid Font source target is invalid Apr 7, 2020
@jessicaschilling jessicaschilling added effort/hours Estimated to take one or several hours good first issue Good issue for new contributors help wanted Seeking public contribution on this issue and removed effort/days Estimated to take multiple days, but less than a week labels Apr 7, 2020
@jessicaschilling jessicaschilling self-assigned this Apr 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dif/easy Someone with a little familiarity can pick up effort/hours Estimated to take one or several hours good first issue Good issue for new contributors help wanted Seeking public contribution on this issue kind/bug A bug in existing code (including security flaws) P2 Medium: Good to have, but can wait until someone steps up status/ready Ready to be worked topic/design-front-end Front-end implementation of UX/UI work
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants