Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

windows-386 binary is not being produced on deploy #165

Closed
daviddias opened this issue Dec 1, 2017 · 4 comments
Closed

windows-386 binary is not being produced on deploy #165

daviddias opened this issue Dec 1, 2017 · 4 comments
Labels
kind/bug A bug in existing code (including security flaws)

Comments

@daviddias
Copy link
Member

daviddias commented Dec 1, 2017 •
edited
Loading

dist.ipfs.io stopped shipping windows-386 binaries and after running the make step in my machine, here is the build log:

# gx/ipfs/Qme3aYm74r4gyMjtZTXpopHkBA6qjU21LXJy4GF56pLkW8/badger/y
../gopath/src/gx/ipfs/Qme3aYm74r4gyMjtZTXpopHkBA6qjU21LXJy4GF56pLkW8/badger/y/mmap_windows.go:70:12: constant 4294967295 overflows int
../gopath/src/gx/ipfs/Qme3aYm74r4gyMjtZTXpopHkBA6qjU21LXJy4GF56pLkW8/badger/y/mmap_windows.go:70:12: array bound is too large

Is this known? Was there a decision of not shipping windows-386 binaries anymore?

I'll be waiting for an answer so that I can do the release dance for js land. ref: ipfs-inactive/npm-go-ipfs-dep#21 (comment)
@daviddias daviddias added kind/bug A bug in existing code (including security flaws) question labels Dec 1, 2017
@Stebalien
Copy link
Member

ipfs/kubo#4438

@Stebalien
Copy link
Member

New tests so this doesn't happen again: ipfs/kubo#4445

@daviddias daviddias mentioned this issue Dec 5, 2017
Merged
@daviddias
Copy link
Member Author

@Stebalien will this be shipped in 0.4.14 only? There is a bunch of CI that fails because appveyor uses the windows-386 version.

@Stebalien
Copy link
Member

It'll be shipped in all future versions. go-ipfs 0.4.13 simply doesn't build on 386 windows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug A bug in existing code (including security flaws)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Stebalien @daviddias