Skip to content
This repository has been archived by the owner on Feb 1, 2023. It is now read-only.

Split server & client and create message dispatcher object #568

Closed
Tracked by #709
guseggert opened this issue Jun 28, 2022 · 4 comments · Fixed by #570
Closed
Tracked by #709

Split server & client and create message dispatcher object #568

guseggert opened this issue Jun 28, 2022 · 4 comments · Fixed by #570
Assignees
Labels
P1 High: Likely tackled by core team if no one steps up

Comments

@guseggert
Copy link
Contributor

guseggert commented Jun 28, 2022

Requirements:

  • Backwards-compatible interface w/ current Bitswap impl, so that this can be integrated easily and provide feedback
  • Wire into Kubo
  • Add configuration so can function as as just a bitswap client or bitswap server
  • Passes a basic test w/ a test harness
    • It's okay for edge cases to be missing, this task is about setting up the scaffolding and feedback loop needed to complete Separable client and server implementations #564
    • Two tests
      • Private network of nodes
        • This is so we have a place to test specific scenarios
      • Peer w/ ipfs.io gateways and handle Bitswap reqs from gateways
        • So that we can test against realistic production traffic

The intention was to deploy this to a cluster to get some perf feedback, but that is looking harder than anticipated, so we should just bite the bullet and setup a proper test harness as part of this.

@guseggert guseggert added the need/triage Needs initial labeling and prioritization label Jun 28, 2022
@guseggert guseggert moved this to 🏃‍♀️ In Progress in IPFS Shipyard Team Jun 28, 2022
@Jorropo Jorropo added P1 High: Likely tackled by core team if no one steps up and removed need/triage Needs initial labeling and prioritization labels Jun 28, 2022
@Jorropo Jorropo changed the title Create server-client bridge Split server & client and create message dispatcher object Jun 28, 2022
@BigLep
Copy link

BigLep commented Jul 26, 2022

@guseggert : what is the done criteria for this issue?

@Jorropo
Copy link
Contributor

Jorropo commented Jul 26, 2022

@BigLep merging #570

@BigLep BigLep mentioned this issue Aug 12, 2022
72 tasks
@BigLep BigLep moved this from 🏃‍♀️ In Progress to 🔎 In Review in IPFS Shipyard Team Aug 12, 2022
Repository owner moved this from 🔎 In Review to 🎉 Done in IPFS Shipyard Team Aug 13, 2022
@BigLep
Copy link

BigLep commented Aug 15, 2022

@Jorropo and @guseggert : since this is closed, I wanted to confirm all the requirements in the issue are satisfied.

@Jorropo
Copy link
Contributor

Jorropo commented Aug 15, 2022

Yes it is.

@BigLep BigLep moved this from 🎉 Done to ☑️ Done (Archive) in IPFS Shipyard Team Aug 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
P1 High: Likely tackled by core team if no one steps up
Projects
No open projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants