Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consider moving _rsrch/cidiface to internal #168

Closed
MichaelMure opened this issue Sep 24, 2024 · 3 comments
Closed

consider moving _rsrch/cidiface to internal #168

MichaelMure opened this issue Sep 24, 2024 · 3 comments
Labels
P2 Medium: Good to have, but can wait until someone steps up

Comments

@MichaelMure
Copy link
Contributor

As I understand, _rsrch/cidiface is an engineering experiment package to explore the right form for a CID. As such, it's not meant to be actually used, and could result in conflict if used. There is definitely value in that package, if only to document design choices.

My (admittedly little) issue is that my IDE keeps suggesting me to import that package, and sometimes does. It would be way less confusing for everyone if _rsrch/cidiface would be moved into internal/_rsrch/cidiface or something similar.

@MichaelMure MichaelMure added the need/triage Needs initial labeling and prioritization label Sep 24, 2024
Copy link

welcome bot commented Sep 24, 2024

Thank you for submitting your first issue to this repository! A maintainer will be here shortly to triage and review.
In the meantime, please double-check that you have provided all the necessary information to make this process easy! Any information that can help save additional round trips is useful! We currently aim to give initial feedback within two business days. If this does not happen, feel free to leave a comment.
Please keep an eye on how this issue will be labeled, as labels give an overview of priorities, assignments and additional actions requested by the maintainers:

  • "Priority" labels will show how urgent this is for the team.
  • "Status" labels will show if this is ready to be worked on, blocked, or in progress.
  • "Need" labels will indicate if additional input or analysis is required.

Finally, remember to use https://discuss.ipfs.io if you just need general support.

@gammazero gammazero added P2 Medium: Good to have, but can wait until someone steps up and removed need/triage Needs initial labeling and prioritization labels Sep 24, 2024
@gammazero
Copy link
Contributor

Sounds like a good idea. PR would be great. Either move it to internal or remove it if no longer needed.

@MichaelMure
Copy link
Contributor Author

@gammazero here is the PR: #169

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 Medium: Good to have, but can wait until someone steps up
Projects
None yet
Development

No branches or pull requests

2 participants