-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Is this repo actually used? #10
Comments
See #5 as an example of drift from canonical behaviour. |
You appear to be correct. I've filed a bug in go-ipfs: ipfs/kubo#5902 |
@anacrolix per the discussion on the go-ipfs issue, want to put together a PR with a note deprecating this? Leaving buggy repos around for users to trip over is not particularly nice. |
What about just removing it entirely, and directing to ipfs/go-ipfs/namesys? The repo's existence alone will lead consumers of the PL ecosystem to assume that it contains the implementation of dnslink. |
I try not to break links (and code we may not know about) unless we really need to. Instead, we can:
|
I use this. don't delete it. This tool is standalone-- do not deprecate it. It's not harming anybody. If you don't want it, transfer it to me. i'll keep it. We build modular tools that can be used for a variety of things. Stop removing things, just because you don't use them. Imagine if people started removing tools from the unix or gnu toolchain! Stop breaking things. we are the group of people that believe in not breaking links. |
Sounds like @anacrolix is bothered by the note But for those of us who use the cli tool-- don't break us |
We should add a notice explaining that it hasn't been kept up-to-date with the spec and is no longer maintained. The idea behind archiving is to clearly communicate that. It leaves it in place for people using it but makes it clear that it may not work as expected. Concretely, this tool:
|
that's backwards. note: dnslink is not just for ipfs. perhaps, dnslink should live in multiformats org not in ipfs org.
I don't think archiving is a good mode for that. Put a bold, clear notice that says:
|
I can't find any packages that reference this repository (and none are shown on godoc.org). Functionality seems to be reimplemented in
github.com/ipfs/go-ipfs/namesys
. As such I think it's potentially misleading to have an implementation that can drift from the official IPFS behaviour. Theipfs
tool has thedns
subcommand, among others that perform the behaviour in this package. Perhaps it should be deleted?The text was updated successfully, but these errors were encountered: