Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore non-IPFS content paths in DNSLink records #14

Open
martinheidegger opened this issue May 10, 2021 · 4 comments
Open

Ignore non-IPFS content paths in DNSLink records #14

martinheidegger opened this issue May 10, 2021 · 4 comments
Labels
effort/hours Estimated to take one or several hours exp/novice Someone with a little familiarity can pick up help wanted Seeking public contribution on this issue P3 Low: Not priority right now status/ready Ready to be worked

Comments

@martinheidegger
Copy link

martinheidegger commented May 10, 2021 •
edited
Loading

DNSLink currently returns the first non /dns-prefixed dnslink which means that per domain it is possible to use dnslink for only one "protocol". In order for dnslink to become useful for different decentralized protocols (hyper/dat, earthlink, etc.) it would need an option to specify a particular protocol to be looked for. Would you be open to a PR adding an option to this repo, defaulting to IPFS?

(Related issue on js-dnslink: here)
@martinheidegger martinheidegger added the need/triage Needs initial labeling and prioritization label May 10, 2021
@welcome

This comment has been minimized.

Sign in to view
@martinheidegger martinheidegger mentioned this issue Jan 8, 2024
Closed
@aschmahmann
Copy link

Yes, a PR would be welcome. However, the PR should go into go-namesys as that is the more used library for dnslink at the moment.

@aschmahmann aschmahmann added status/ready Ready to be worked need/analysis Needs further analysis before proceeding and removed need/triage Needs initial labeling and prioritization labels May 10, 2021
@martinheidegger
Copy link
Author

@aschmahmann Probably somewhere here: https://github.com/ipfs/go-namesys/blob/2454122ef30efa1f4f86ffab33ea34b05eb848fe/dns.go#L171-L178, right?

@lidel
Copy link
Member

lidel commented May 11, 2021 •
edited
Loading

@martinheidegger yes, we want to skip records where does not start with /ipns/ or /ipfs/ (right now it errors). Adding strings.HasPrefix check should do the trick.

We should also interpret /dnslink as /ipns and try to resolve it to the final form.

@lidel lidel added help wanted Seeking public contribution on this issue exp/novice Someone with a little familiarity can pick up P2 Medium: Good to have, but can wait until someone steps up effort/hours Estimated to take one or several hours P3 Low: Not priority right now and removed need/analysis Needs further analysis before proceeding P2 Medium: Good to have, but can wait until someone steps up labels Apr 22, 2022
@lidel lidel changed the title Support for more than one dnslink option Ignore non-IPFS content paths in DNSLink records Apr 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
effort/hours Estimated to take one or several hours exp/novice Someone with a little familiarity can pick up help wanted Seeking public contribution on this issue P3 Low: Not priority right now status/ready Ready to be worked
Projects
No open projects
IPFS Shipyard Team
Status: 🥞 Todo
Milestone
No milestone
Development

No branches or pull requests
3 participants
@lidel @martinheidegger @aschmahmann