Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error when invoking IPFS concurrently #6434

Closed
Stebalien opened this issue Jun 12, 2019 · 6 comments
Closed

Improve error when invoking IPFS concurrently #6434

Stebalien opened this issue Jun 12, 2019 · 6 comments
Labels
good first issue Good issue for new contributors help wanted Seeking public contribution on this issue kind/enhancement A net-new feature or improvement to an existing feature

Comments

@Stebalien
Copy link
Member

Currently, we return "resource temporarily unavailable" which is the underlying error returned when we fail to lock the repo. However, that doesn't tell the user what's going on.

We should replace that error with "IPFS currently running", or something like that.

@Stebalien Stebalien added kind/enhancement A net-new feature or improvement to an existing feature help wanted Seeking public contribution on this issue good first issue Good issue for new contributors labels Jun 12, 2019
@utkarsh5k
Copy link

Looking to get involved with this project. I can pick this up.

@Stebalien
Copy link
Member Author

Awesome! I believe the correct way to fix this is to modify the Lock function in github.com/ipfs/go-fs-lock to inspect the error. Really, this should probably move some of the error handling code from the Locked function into the Lock function.

@mahekchheda
Copy link

Is this still up for grabs? I would like to start contributing to this project from this.

@Stebalien
Copy link
Member Author

@leiter-jakab
Copy link

Hi, I created a pull request for this issue ipfs/go-fs-lock#9. I would be glad to hear your feedback. Unfortunately I didn't manage to link up the commits with this issue, because it's in a different repository.

@leiter-jakab
Copy link

@Stebalien I think this issue has been solved with ipfs/go-fs-lock#9.

Stebalien added a commit that referenced this issue Oct 14, 2019
Stebalien added a commit that referenced this issue Oct 14, 2019
Stebalien added a commit that referenced this issue Dec 11, 2019
pontiyaraja pushed a commit to pontiyaraja/go-ipfs that referenced this issue Dec 27, 2019
* fixes ipfs#6434
* switches the default libp2p multiaddr format to /p2p/Qm...
ralendor pushed a commit to ralendor/go-ipfs that referenced this issue Jun 6, 2020
* fixes ipfs#6434
* switches the default libp2p multiaddr format to /p2p/Qm...
ralendor pushed a commit to ralendor/go-ipfs that referenced this issue Jun 6, 2020
* fixes ipfs#6434
* switches the default libp2p multiaddr format to /p2p/Qm...
ralendor pushed a commit to ralendor/go-ipfs that referenced this issue Jun 8, 2020
* fixes ipfs#6434
* switches the default libp2p multiaddr format to /p2p/Qm...
ralendor pushed a commit to ralendor/go-ipfs that referenced this issue Jun 8, 2020
* fixes ipfs#6434
* switches the default libp2p multiaddr format to /p2p/Qm...
ralendor pushed a commit to ralendor/go-ipfs that referenced this issue Jun 8, 2020
* fixes ipfs#6434
* switches the default libp2p multiaddr format to /p2p/Qm...
ralendor pushed a commit to ralendor/go-ipfs that referenced this issue Jun 8, 2020
* fixes ipfs#6434
* switches the default libp2p multiaddr format to /p2p/Qm...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good issue for new contributors help wanted Seeking public contribution on this issue kind/enhancement A net-new feature or improvement to an existing feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants