-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ISSUE_TEMPLATE.md #2786
Add ISSUE_TEMPLATE.md #2786
Conversation
In my opinion we shouldn't be using headers to note informations. It will get a bit annoying. Also there was talk about adding note at the bottom that is information about that go-ipfs repo is about bug reports and directly actionable features. More complex feature requests and general questions should go into different repos. |
There are no headers any more. About the note at the bottom, I think it could get annoying too. Isn't there another place where we could tell that? |
No, it is the best we have came up with (as a fix for big number of non-actionable issues in the repo). I would place it at the bottom with something like:
|
Ok, here is a version close to what you suggest. It seems a bit verbose to me though. Couldn't we just provide one link from where the user could get more information about the appropriate places? |
This might be a good idea. A central hub to redirect peoples' issues (also this @whyrusleeping what do you think? |
We could better detail where issues should be reported here for example: https://github.com/ipfs/community/blob/master/contributing.md#reporting-issues |
Yeah, this section needs improvements as well. I would go with what we've got here (thanks) and possibly improve it in future. |
@@ -0,0 +1,16 @@ | |||
Operating system version & Platform: | |||
IPFS commit version (from `ipfs version --commit`): | |||
IPFS repo version (from `ipfs version --repo`): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we need the repo version, if we know the commit, or even just the general semver we can infer it. It might be better to ask for 'ipfs version (and commit, if known)'
cc @em-ly |
Thanks @whyrusleeping. We met today and created some prelimary template outline for the Issues template for https://github.com/ipfs/go-ipfs/ Type: Platform: Processor: Area: Priority: Anything else need to be included? |
With PR #2790 the versions/platform/processor can be dealt with using @em-ly I am not sure how it is possible, without being very verbose, to ask someone reporting an issue to select the Type, Area and Priority as per the above in a issue template. Or do you mean that we should have something like:
and the "how to report an issue" linked document would show all the possible values for the Type, Area and Priority fields? |
@chriscool for me it looks great. Only think is that we don't (and shouldn't) use markdown formatting for links as people will see the template mostly in the raw form. |
|
||
|
||
--------------------------------------------------- | ||
Please read and then delete |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"This is for you! Please read, and then delete this text before posting it."
What about linking to support? What is ipfs/support for, then? |
License: MIT Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
@RichardLitt @em-ly and @Kubuxu here is a new version that tries to take into account what you suggested. Anyway before this can be merged we need at least the following:
And yeah perhaps we could also add a link to ipfs/support too. |
Made this: ipfs/community#128 Agreed about making a "How to report an issue" for go-ipfs specifically. Happy to do that. |
The information should be best effort by the user, we can correct and fill stuff in post-filing as we see fit |
@RichardLitt thanks for ipfs/community#128! |
I'm off hiking for a week, but happy to do this when I get back. |
And back. Will be addressing this this week. |
@RichardLitt @em-ly update here? |
@RichardLitt is going to work on getting this completed for this week! On Tue, Jun 21, 2016 at 12:57 PM, Jeromy Johnson notifications@github.com
Emily Moore |
See #2786 License: MIT Signed-off-by: Richard Littauer <richard.littauer@gmail.com>
Created #2889. This should be good to go, now? |
Yeah, when PR #2889 is merged, I will update this and it should be good to go. |
I would do something like: Version information:
|
See #2786 License: MIT Signed-off-by: Richard Littauer <richard.littauer@gmail.com>
See #2786 License: MIT Signed-off-by: Richard Littauer <richard.littauer@gmail.com>
See #2786 License: MIT Signed-off-by: Richard Littauer <richard.littauer@gmail.com>
#2889 is merged! |
LGTM. Let's try it! |
is this RFM? |
LGTM! Thanks for all the work on this @chriscool @RichardLitt and @Kubuxu! Let's roll this out and test it throughout the week, edits made as necessary. |
Feedback time, I think we need to use something much more minimal, there is too much text in the template and its a bit overwhelming to users who most of the time won't have any idea what half of it means. I propose something closer to:
Using a bit of a hack for markdown comments that the user will see when creating the issue, but that wont render when the issue itself is viewed. |
Looks very good to me! |
I just discovered you can use html comments in these, take a look at the template from nodejs/node: https://raw.githubusercontent.com/nodejs/node/master/.github/ISSUE_TEMPLATE.md These templates also seem to be quite useful and working |
@dignifiedquire oooooh, good find! I like that a little better than the empty link hovertext hack i'm using |
Also worth taking into account: the repos in this repository: https://github.com/devspace/awesome-github-templates |
The current issue template is a bit cumbersome. maybe it's just how the formatting works. consider these that @RichardLitt posted: https://github.com/devspace/awesome-github-templates and how they do it. headings may be a good way to ask questions |
This addresses issue #2770.