Stable bits from Pull Request #2634 #2792
Conversation
License: MIT Signed-off-by: Kevin Atkinson <k@kevina.org>
kevina
force-pushed
the
kevina/filestore-bits
branch
from
ef9c724
to
0a9015a
Compare
|
I think continuous-integration/travis-ci/pr was getting confused as I committed two commits shortly after one another and it was attempting to build with the wrong commit id. Commit dbabcf9 does not touch |
|
@whyrusleeping this is ready for you to have a look, and okay with me if it gets merged. |
| @@ -54,7 +54,8 @@ func TestAddGCLive(t *testing.T) { | |||
|
|
|||
| errs := make(chan error) | |||
| out := make(chan interface{}) | |||
| adder, err := NewAdder(context.Background(), node, out) | |||
| adder, err := NewAdder(context.Background(), node.Pinning, node.Blockstore, node.DAG) | |||
| adder.Out = out | |||
There was a problem hiding this comment.
just in case (even though its a test), i'd put the adder.Out = out after the error check. If this call does error for some reason, its going to return a nil adder and we will panic on this line and lose information about what the real error was
There was a problem hiding this comment.
Oops. Your right fixed.
|
One nitpick then LGTM |
kevina
force-pushed
the
kevina/filestore-bits
branch
from
0a9015a
to
a70876e
Compare
This will make it easier to set up a specialized data pipeline. License: MIT Signed-off-by: Kevin Atkinson <k@kevina.org>
kevina
force-pushed
the
kevina/filestore-bits
branch
from
a70876e
to
9360f5c
Compare
|
@whyrusleeping,okay I fixed the nitpick and all tests are passing. |
|
sweet, LGTM |
| @@ -20,47 +20,47 @@ type Block interface { | |||
| } | |||
|
|
|||
| // Block is a singular block of data in ipfs | |||
| type RawBlock struct { | |||
| type BasicBlock struct { | |||
There was a problem hiding this comment.
Stable bits from Pull Request #2634.