respect contexts while reading messages in dht #2826
Conversation
| @@ -227,3 +228,23 @@ func (ms *messageSender) SendRequest(ctx context.Context, pmes *pb.Message) (*pb | |||
|
|
|||
| return mes, nil | |||
| } | |||
|
|
|||
| func (ms *messageSender) ctxReadMsg(ctx context.Context, mes *pb.Message) error { | |||
| t := time.NewTimer(time.Second * 30) | |||
There was a problem hiding this comment.
I think we should collect all of those timeouts (and create a one that would be standard), this way if we need to make IPFS work over higher latency for some reason it will be much easier.
There was a problem hiding this comment.
I honestly think we could get away without the timeout here and just stick to respecting the context and fixing utp.
What do you think?
There was a problem hiding this comment.
theres a bug in utp that surfaces occasionally that will cause it to hang. Theres nothing we can do to avoid this other than fix utp, or not use utp. The hang that i wrote this PR to 'solve' was caused by this utp bug.
There was a problem hiding this comment.
Ok, let's pull it but we should remember to fix it properly in future.
License: MIT Signed-off-by: Jeromy <why@ipfs.io>
whyrusleeping
force-pushed
the
fix/dht-ctx-respect
branch
from
b3503e0
to
73463cd
Compare
respect contexts while reading messages in dht
If something weird happens during a dht request and the remote peer does not reply to our request, and also does not close the underlying connection, this has the possibility to hang.
That said, I think that the issue i noticed was caused by utp hanging up under the hood (the stack trace showed a few utp event loops running)
License: MIT
Signed-off-by: Jeromy why@ipfs.io