Feat/backoff clear connect #2941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
License: MIT Signed-off-by: Jeromy <why@ipfs.io>
License: MIT Signed-off-by: Jeromy <why@ipfs.io>
|
LGTM I don't know but last time I looked at it it was hidden much deeper (even including the go-libp2p patch) but it might have been me not knowing libp2p back then at all. |
|
Other thing: should we have tests for it? |
|
@Kubuxu Yeah, we should probably have tests for this. But i'm not sure how to reliably do them. |
License: MIT Signed-off-by: Jeromy <why@ipfs.io>
|
LGTM let's wait for the test. |
| @@ -241,6 +249,8 @@ ipfs swarm connect /ip4/104.131.131.82/tcp/4001/ipfs/QmaCpDMGvV2BGHeYERUEnRQAwe3 | |||
|
|
|||
| output := make([]string, len(pis)) | |||
| for i, pi := range pis { | |||
| swrm.Backoff().Clear(pi.ID) | |||
There was a problem hiding this comment.
this is leaking the underlying abstraction. can this be turned into something more "user/client" oriented? Not sure what name would fit
ariescodescream
pushed a commit
to ariescodescream/go-ipfs
that referenced
this pull request
Oct 23, 2021
Feat/backoff clear connect
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2456