add option to enable go-multiplex experiment #3447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whyrusleeping
force-pushed
the
feat/multiplex-experiment
branch
from
7165d65
to
0a5242c
Compare
whyrusleeping
force-pushed
the
feat/multiplex-experiment
branch
2 times, most recently
from
1629405
to
eedbcc5
Compare
daviddias
requested changes
Dec 5, 2016
| mstpt.AddTransport("/spdy/3.1.0", spdy.Transport) | ||
|
|
||
| if mplexExp { | ||
| mstpt.AddTransport("/mplex/1.0.0", mplex.DefaultTransport) |
There was a problem hiding this comment.
Since multiplex doesn't have a formal spec, the best we can do is follow its semver from its main implementation. See:
https://github.com/libp2p/specs/blob/master/7-properties.md#757-protocol-multicodecs
multiplex /multiplex/6.7.0
whyrusleeping
force-pushed
the
feat/multiplex-experiment
branch
from
eedbcc5
to
10ddd40
Compare
License: MIT Signed-off-by: Jeromy <why@ipfs.io>
daviddias
approved these changes
Dec 5, 2016
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
License: MIT
Signed-off-by: Jeromy why@ipfs.io