merkledag: add a concurrency limit to merkledag fetch graph #3495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kubuxu
reviewed
Dec 9, 2016
| @@ -458,8 +458,13 @@ func fetchNodes(ctx context.Context, ds DAGService, in <-chan []*cid.Cid, out ch | |||
| close(out) | |||
| }() | |||
|
|
|||
| rateLimit := make(chan struct{}, 8) | |||
There was a problem hiding this comment.
It would be better to have this magic number extracted and documented.
There was a problem hiding this comment.
FIIINE.
// Eight is 2 to the third power, alternatively it can be represented as 7+1, or the cube root of 512
var Eight = 8
There was a problem hiding this comment.
It's also what you get when you multiply a random number with two!
whyrusleeping
force-pushed
the
fix/fetch-graph-concurrency
branch
from
d61fe5a
to
0c14b41
Compare
License: MIT Signed-off-by: Jeromy <why@ipfs.io>
Kubuxu
approved these changes
Dec 10, 2016
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should help solve a few 'cant pin giant things' issues.
License: MIT
Signed-off-by: Jeromy why@ipfs.io