Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bootstrap: add a few /ip6 nodes #3523

Merged
merged 1 commit into from
Feb 17, 2017
Merged

bootstrap: add a few /ip6 nodes #3523

merged 1 commit into from
Feb 17, 2017

Conversation

ghost
Copy link

@ghost ghost commented Dec 19, 2016

As the bootstrappers now have proper IPv6, we can start making use of it. Since configuring it over the weekend, IPv6 usage has already roughly quadrupled.

License: MIT
Signed-off-by: Lars Gierth <larsg@systemli.org>
@ghost ghost added topic/discovery Topic discovery status/in-progress In progress need/review Needs a review labels Dec 19, 2016
@whyrusleeping
Copy link
Member

@lgierth do you want this in 0.4.5?

@ghost
Copy link
Author

ghost commented Dec 20, 2016

Ideally yes, I just wasn't sure if you had any reservations :)

@ghost
Copy link
Author

ghost commented Dec 22, 2016

Is there any place where we explicitly prefer /ip6 over /ip4? That'd be useful.

@jbenet
Copy link
Member

jbenet commented Dec 22, 2016

yay

@whyrusleeping whyrusleeping added this to the ipfs 0.4.6 milestone Jan 5, 2017
@whyrusleeping
Copy link
Member

@lgierth that happens in libp2p in the addrutil sorter: https://github.com/libp2p/go-libp2p-peerstore/blob/master/addr/sorting.go

@mib-kd743naq
Copy link
Contributor

Linking here as very tightly related: ipfs/ipfs#221

The issue isn't theoretical - I actually was in a situation like this when I filed the ticket ( fully open 80/443 outbound, everything else was a hard REJECT )

@whyrusleeping
Copy link
Member

@lgierth do we want to take this opportunity to add some 'standard' port bootstrappers?

@ghost
Copy link
Author

ghost commented Feb 12, 2017

Do you mean 4737?

@Kubuxu
Copy link
Member

Kubuxu commented Feb 12, 2017

I think he meant 443 and 80.

@ghost
Copy link
Author

ghost commented Feb 12, 2017

I dunno -- we'll have /ws on ipfs.io:80 and /wss on ipfs.io:443 very soon, I figure that'd work?

@whyrusleeping
Copy link
Member

@lgierth okay, I think we can merge this as is for 0.4.6 then, yeah?

@mib-kd743naq
Copy link
Contributor

I dunno -- we'll have /ws on ipfs.io:80 and /wss on ipfs.io:443 very soon, I figure that'd work?

@lgierth will this fully address ipfs/ipfs#221 (comment) ( given one uses a 0.4.<distantfuture> go-ipfs instance )? Or will the ws-based transport be useful for the js-ipfs exclusively?

@ghost
Copy link
Author

ghost commented Feb 17, 2017

okay, I think we can merge this as is for 0.4.6 then, yeah?

Yes let's do it! 👍

Or will the ws-based transport be useful for the js-ipfs exclusively?

@mib-kd743naq I think it's pretty useful generally -- on the outside it just looks like regular HTTPS.

@whyrusleeping whyrusleeping merged commit 765fb0f into master Feb 17, 2017
@whyrusleeping whyrusleeping deleted the feat/ipv6-bootstrap branch February 17, 2017 01:00
@whyrusleeping whyrusleeping removed the status/in-progress In progress label Feb 17, 2017
@ghost ghost restored the feat/ipv6-bootstrap branch May 18, 2017 02:57
@ghost ghost deleted the feat/ipv6-bootstrap branch June 8, 2017 02:25
laurentsenta pushed a commit to laurentsenta/kubo that referenced this pull request Feb 25, 2022
laurentsenta pushed a commit to laurentsenta/kubo that referenced this pull request Feb 25, 2022
laurentsenta pushed a commit to laurentsenta/kubo that referenced this pull request Mar 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need/review Needs a review topic/discovery Topic discovery
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants