Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"ipfs name publish": use path.ParsePath instead of casting input #3592

Merged
merged 1 commit into from
Jan 12, 2017
Merged

"ipfs name publish": use path.ParsePath instead of casting input #3592

merged 1 commit into from
Jan 12, 2017

Conversation

kevina
Copy link
Contributor

@kevina kevina commented Jan 12, 2017

Towards #3534

@kevina
"ipfs name publish": use path.ParsePath instead of casting input
6657b83 
License: MIT
Signed-off-by: Kevin Atkinson <k@kevina.org>
@kevina kevina added the status/in-progress In progress label Jan 12, 2017
@kevina kevina mentioned this pull request Jan 12, 2017
Closed
@kevina kevina added this to the ipfs 0.4.5 milestone Jan 12, 2017
whyrusleeping
whyrusleeping approved these changes Jan 12, 2017
View reviewed changes
Copy link
Member

@whyrusleeping whyrusleeping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @kevina!

@whyrusleeping whyrusleeping merged commit f8ba7c0 into master Jan 12, 2017
@whyrusleeping whyrusleeping deleted the kevina/publish-parse-path branch January 12, 2017 21:41
@whyrusleeping whyrusleeping removed the status/in-progress In progress label Jan 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whyrusleeping whyrusleeping whyrusleeping approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
ipfs 0.4.5
Development

Successfully merging this pull request may close these issues.
2 participants
@kevina @whyrusleeping