Tests for mfsr.go #3618
Merged
Tests for mfsr.go #3618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zmackie
force-pushed
the
test/msfr-test
branch
from
37b869d
to
77e46b4
Compare
| @@ -23,8 +23,8 @@ func (rp RepoPath) Version() (int, error) { | |||
| } | |||
|
|
|||
| fn := rp.VersionFile() | |||
| if _, err := os.Stat(fn); os.IsNotExist(err) { | |||
| return 0, VersionFileNotFound(rp) | |||
| if _, err := os.Stat(fn); err != nil { | |||
There was a problem hiding this comment.
I removed this because I noticed that the only caller of the method (https://github.com/Zanadar/go-ipfs/blob/77e46b40b1ec1e7799915c6dd1a4a38e9d741622/repo/fsrepo/fsrepo.go#L142) explicitly checks for os.IsNotExist(err) and when we transform the error here, that check in the caller never returns true.
On second consideration, it may be better to check in the caller for err == VersionFileNotFound as this error gives a little more context.
Hope that clarifies.
There was a problem hiding this comment.
Ah, that makes sense then.
|
@Zanadar do you mind rebasing this PR on latest master? To get CI on jenkins running properly we need the new makefile changes |
License: MIT Signed-off-by: Zander Mackie <zmackie@gmail.com>
- fsrepo calls and checks for this error (`fsrepo.go:140`) License: MIT Signed-off-by: Zander Mackie <zmackie@gmail.com>
License: MIT Signed-off-by: Zander Mackie <zmackie@gmail.com>
License: MIT Signed-off-by: Zander Mackie <zmackie@gmail.com>
zmackie
force-pushed
the
test/msfr-test
branch
from
77e46b4
to
310c08c
Compare
|
Rebased. |
whyrusleeping
approved these changes
Mar 2, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds tests for
msfr.go. Does not hit coverage target of 80%.Remove code that was transforming errs when the version file didn't exist, which may have confused callers of the
Versionmethod.