update go-multihash and bubble up deps #3649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whyrusleeping
force-pushed
the
deps/update-multihash
branch
3 times, most recently
from
dddb42c
to
1dc1ec9
Compare
|
Is it too late to introduce into go-cid utility method that would be equivalent of |
|
@Kubuxu we could do it now. Though would be just as easy to do later. Up to you |
|
As I understand it includes varint update to multihash, then it will require quite some testing. |
License: MIT Signed-off-by: Jeromy <jeromyj@gmail.com>
whyrusleeping
force-pushed
the
deps/update-multihash
branch
from
1dc1ec9
to
b4eeff2
Compare
|
rebased on master |
|
I'm thinking that because of this one, we will probably want to ship a pre-release of 0.4.6 next week so that the hex encoded cids will work for browser integration stuff. |
|
Ok, lets do it, as the tree update was already done, redoing it has the same cost. LGTM if tests pass. |
hacdias
pushed a commit
to ipfs/boxo
that referenced
this pull request
Jan 27, 2023
update go-multihash and bubble up deps This commit was moved from ipfs/kubo@2e116b4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated go-multihash with the blake2b and 'double sha256' changes. This was a large process.
Other than the go-multihash changes, two other changes were made:
go-multibase was updated in go-cid
one tree bubbling was enough, and its a minor change.
the 'go-net' package had its go-crypto dependency removed
This was done because go-multihash was updated to use a new version of go-crypto, and no user of the 'go-net' package used the code in go-net that required go-crypto.
License: MIT
Signed-off-by: Jeromy jeromyj@gmail.com