implement ipfs pin update #3846
Conversation
|
I'll want a solid review of the algorithm here |
whyrusleeping
force-pushed
the
feat/pin-update
branch
from
f8b0191
to
ecd1a24
Compare
| cmds.StringArg("to-path", true, false, "Path to new object to be pinned."), | ||
| }, | ||
| Options: []cmds.Option{ | ||
| cmds.BoolOption("unpin", "Remove the old pin.").Default(true), |
There was a problem hiding this comment.
What is the use case of update with no unpin?
There was a problem hiding this comment.
Its if you want to use the optimized pinning functionality and still keep the old pin
There was a problem hiding this comment.
Ahh, right, because it will piggy bank on the already pinned hashes.
merkledag/utils/diffenum.go
Outdated
| sset := cid.NewSet() | ||
| for _, c := range diff { | ||
| if c.a == nil { | ||
| err := mdag.EnumerateChildrenAsync(ctx, mdag.GetLinksDirect(dserv), c.b, sset.Visit) |
merkledag/utils/diffenum.go
Outdated
| } | ||
|
|
||
| type diffpair struct { | ||
| a, b *cid.Cid |
There was a problem hiding this comment.
I would rename it to old, new. It clears up a lot.
There was a problem hiding this comment.
cant use 'new' lol, its a keyword
merkledag/utils/diffenum.go
Outdated
| a, b *cid.Cid | ||
| } | ||
|
|
||
| func getLinkDiff(a, b node.Node) []diffpair { |
There was a problem hiding this comment.
It took me a minute to properly get what this function does but now I understand.
It diffs links as a set, it doesn't matter for it if some link is repeated.
merkledag/utils/diffenum.go
Outdated
| return err | ||
| } | ||
| } else { | ||
| err := DiffEnumerate(ctx, dserv, c.a, c.b) |
There was a problem hiding this comment.
Are we worried here about too deep recursion? Should it be turned into loop with TODO list instead?
There was a problem hiding this comment.
Also coverage shows that this isn't tested at all.
|
@whyrusleeping I would like to review this but it may take up to week before I can get to it. |
merkledag/utils/diffenum.go
Outdated
| type diffpair struct { | ||
| bef, aft *cid.Cid | ||
| } | ||
|
|
There was a problem hiding this comment.
Although it is fairly easy to figure out, I would add a note on the meaning of bef and aft, something along the line of replace bef with aft if bef is nil, than insert aft.
merkledag/utils/diffenum.go
Outdated
| bef, aft *cid.Cid | ||
| } | ||
|
|
||
| // getLinkDiff returns a changset (minimum edit distance style) between nodes |
There was a problem hiding this comment.
I was rather confused by what this is doing. From the code it is fairly clear but the phrase "minimum edit distance style" confused me. As someone who wrote a spell checker I was expecting a traditional edit dist algo, and was very confused my the use of the maps. I would probably have had an easier time understanding what is going on if I wasn't trying to reconcile the code with what a traditional string edit dist. algo would be doing.
pin/pin.go
Outdated
| // Update updates a recursive pin from one cid to another | ||
| // this is more efficient than simply pinning the new one and unpinning the | ||
| // old one | ||
| Update(context.Context, *cid.Cid, *cid.Cid, bool) error |
There was a problem hiding this comment.
I would name the parameters here. The use of the bool in Update differs from the use in pin and unpin.
License: MIT Signed-off-by: Jeromy <jeromyj@gmail.com>
License: MIT Signed-off-by: Jeromy <jeromyj@gmail.com>
whyrusleeping
force-pushed
the
feat/pin-update
branch
from
3d08011
to
f326dd8
Compare
License: MIT Signed-off-by: Jeromy <jeromyj@gmail.com>
whyrusleeping
force-pushed
the
feat/pin-update
branch
from
f326dd8
to
0d3a86e
Compare
Makes re-pinning a slightly changed dataset much faster
License: MIT
Signed-off-by: Jeromy jeromyj@gmail.com