Fixes #4003 #4053
Fixes #4003 #4053
Conversation
|
This broke quite many things in tests, see for yourself: https://ci.ipfs.team/blue/organizations/jenkins/go-ipfs/detail/PR-4053/1/pipeline/ |
|
Yep, pretty sure I know what it is. |
License: MIT Signed-off-by: Mateja Milosevic <minima38123@gmail.com>
|
From the looks of it, the only thing that makes the test fail is the fact that now some commands which should output an error output a different error higher up the stack. I apologize, but I haven't had contact with such a developed repository before; should I have modified the tests to reflect the fact I changed the position in the stack the error happens? If so, how? |
|
Right, the refactor of commands lib is being worked on at https://github.com/ipfs/go-ipfs-cmds The early exit on too little arguments is interesting. We are able to provide more info to the user if he misses some arguments, but we are more susceptible to possible bug without it. |
License: MIT Signed-off-by: Mateja Milosevic <minima38123@gmail.com>
|
After a little discussion on the irc, it's better to leave just the regular, bug-specific check in. Tests still fail. Give me a little time to fix this. |
|
It was decided that for now, a bandaid fix for this edgecase was enough. It is not certain if this kind of problems will happen again, if they do, a new issue can be created and further solutions can be discussed. |
License: MIT Signed-off-by: Mateja Milosevic <minima38123@gmail.com>
|
Could you add a test case in sharness that demonstrates what was the problem before. |
License: MIT Signed-off-by: Mateja Milosevic <minima38123@gmail.com>
|
Done. |
Includes a general sanity check to skip further checks if user provided fewer arguments than minimum required and a specific check for corrupted data passed as file.
License: MIT
Signed-off-by: Mateja Milosevic minima38123@gmail.com