Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Go 1.9 issues #4156

Merged
merged 3 commits into from
Aug 25, 2017
Merged

Fix Go 1.9 issues #4156

merged 3 commits into from
Aug 25, 2017

Conversation

magik6k
Copy link
Member

@magik6k magik6k commented Aug 20, 2017 

21:54:33.692 ERROR metrics-pr: Registering prometheus collector, name: ipfs_fsrepo_datastore_blocks_put_total, error: duplicate metrics collector registration attempted binding.go:74

@magik6k
fix 'file already closed' in Go 1.9
1a93abc 
License: MIT
Signed-off-by: Łukasz Magiera <magik6k@gmail.com>
@magik6k magik6k added this to the Ipfs 0.4.11 milestone Aug 20, 2017
@djdv
Copy link
Contributor

djdv commented Aug 21, 2017

👍 Works on my machine™

go-ipfs version: 0.4.11-dev-1a93abcd6
Repo version: 5
System version: amd64/windows
Golang version: devel +7f7be843e9 Mon Aug 21 02:10:10 2017 +0000

Stebalien
Stebalien approved these changes Aug 21, 2017
View reviewed changes
Copy link
Member

@Stebalien Stebalien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

kevina
kevina suggested changes Aug 21, 2017
View reviewed changes
Copy link
Contributor

@kevina kevina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check seams over complicated see comment.

commands/files/serialfile.go
}
default:
return nil, err
}
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seams over complicated, why not just:

if err != nil && err != os.ErrClosed {
    return nil, err
}

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This error is wrapped within os.PathError, that wouldn't work

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, sorry didn't notice that.

kevina
kevina approved these changes Aug 21, 2017
View reviewed changes
commands/files/serialfile.go
}
default:
return nil, err
}
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, sorry didn't notice that.

@magik6k
Copy link
Member Author

magik6k commented Aug 22, 2017

Added option to pass custom go program to make. The ipfs daemon --init thing is not related to go 1.9 and can be reproduced on go 1.8.

@magik6k
mk: option to pass custom go executable
00590fd 
License: MIT
Signed-off-by: Łukasz Magiera <magik6k@gmail.com>
@hoffmabc hoffmabc mentioned this pull request Aug 25, 2017
Closed
@whyrusleeping
Copy link
Member

@magik6k the travis failures seem odd. Any idea there?

@Stebalien
Copy link
Member

@whyrusleeping which failure?

  • One is the shutdown EOF bug (known).
  • The other two are transient DNS errors (I think). package leb.io/hashland/keccakpg: unrecognized import path "leb.io/hashland/keccakpg" (https fetch: Get https://leb.io/hashland/keccakpg?go-get=1: dial tcp: lookup leb.io on 169.254.169.254:53: server misbehaving)

@magik6k
Copy link
Member Author

magik6k commented Aug 25, 2017

The p2p command one is interesting, looks like ma-pipe helper is unable to write pid file or dies before that happens

@whyrusleeping
Copy link
Member

Ah, yeah, youre right. I missed the initial failure on one of those and the subsequent error messages concerned me.

@Stebalien
Copy link
Member

What's up with the jenkins test run though. Looks like some funky plugin build errors...

@whyrusleeping
Copy link
Member

https://s3.amazonaws.com/archive.travis-ci.org/jobs/267287674/log.txt?X-Amz-Expires=30&X-Amz-Date=20170825T192935Z&X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Credential=AKIAJRYRXRSVGNKPKO5A/20170825/us-east-1/s3/aws4_request&X-Amz-SignedHeaders=host&X-Amz-Signature=622deaa8633fb693fafc43e2d7a0b67d4489e9f5987747f8bacd878168bc6995

@whyrusleeping
Copy link
Member

oh thats a beautiful link

@Stebalien
Copy link
Member

AccessDeniedRequest has expired302017-08-25T19:30:05Z2017-08-25T19:31:41Z1259F2DD2654B0EBxoiIYal2iqGYD4vzWxco71ohl2vm2T98mveUZjdsNsEae0/e8dkL+TedS8xKLQktscu0VHhBlO4=

@magik6k
mk: fix plugin test fail
9c40c31 
License: MIT
Signed-off-by: Łukasz Magiera <magik6k@gmail.com>
@whyrusleeping
Copy link
Member

meh, its just in one of the travis CI sharness failures.

@magik6k
Copy link
Member Author

magik6k commented Aug 25, 2017

That fixed plugin issue, ci green now

@whyrusleeping whyrusleeping merged commit 48476b2 into master Aug 25, 2017
@whyrusleeping whyrusleeping deleted the fix/go19 branch August 25, 2017 22:26
@magik6k magik6k restored the fix/go19 branch November 27, 2017 03:34
@magik6k magik6k deleted the fix/go19 branch November 27, 2017 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kubuxu Kubuxu Kubuxu approved these changes

@kevina kevina kevina approved these changes

@whyrusleeping whyrusleeping whyrusleeping approved these changes

@Stebalien Stebalien Stebalien approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Ipfs 0.4.11
Development

Successfully merging this pull request may close these issues.
6 participants
@magik6k @djdv @whyrusleeping @Stebalien @kevina @Kubuxu