Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update badgerds to 1.1.3 #4384

Merged
merged 1 commit into from
Nov 13, 2017
Merged

Update badgerds to 1.1.3 #4384

merged 1 commit into from
Nov 13, 2017

Conversation

magik6k
Copy link
Member

@magik6k magik6k commented Nov 12, 2017

Fixes #4383.

@ghost ghost assigned magik6k Nov 12, 2017
@ghost ghost added the status/in-progress In progress label Nov 12, 2017
License: MIT
Signed-off-by: Łukasz Magiera <magik6k@gmail.com>
@magik6k
Copy link
Member Author

magik6k commented Nov 13, 2017

@whyrusleeping I know that 0.4.12 has already been tagged, but would it be possible to patch this into 0.4.12 before it's released (on dists, blog, etc)?

@Kubuxu
Copy link
Member

Kubuxu commented Nov 13, 2017

@magik6k I am against ninja versions, I think we have one more problematic bug in 0.4.12.
@whyrusleeping should we just do quick 0.4.13?

@whyrusleeping
Copy link
Member

Ah crap, i could have sworn we had tests for this already. My bad for letting this through code review.

Agree with @Kubuxu, no ninja releases. Lets do 0.4.13 asap (this week) and get this + the bitswap fix into it.

Thanks for the quick fix @magik6k

@whyrusleeping whyrusleeping merged commit 8f8fdc0 into master Nov 13, 2017
@whyrusleeping whyrusleeping deleted the fix/badgerds-1.1.3 branch November 13, 2017 22:52
@ghost ghost removed the status/in-progress In progress label Nov 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants