-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix hamt delete issue #4398
fix hamt delete issue #4398
Conversation
License: MIT Signed-off-by: Jeromy <jeromyj@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@@ -2,6 +2,7 @@ package hamt | |||
|
|||
import ( | |||
"math/big" | |||
"math/bits" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we are adding this we should increase checked Go version to 1.9 in package.json and Makefiles.
c408c7b
to
d0e589a
Compare
License: MIT Signed-off-by: Jeromy <jeromyj@gmail.com>
d0e589a
to
1a75c40
Compare
License: MIT Signed-off-by: Jeromy <jeromyj@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think LGTM but HAMT code is a bit of mystery to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To the best of my understanding, this looks right.
Found this while writing another hamt (using ipld :) )
License: MIT
Signed-off-by: Jeromy jeromyj@gmail.com