Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Demote bitswap error to an info #4472

Merged
merged 1 commit into from
Dec 9, 2017
Merged

Demote bitswap error to an info #4472

merged 1 commit into from
Dec 9, 2017

Conversation

Stebalien
Copy link
Member

@Stebalien Stebalien commented Dec 8, 2017 •
edited
Loading

Not being able to dial a peer we used to be connected to is interesting but definitely not an error.

fixes #4472

@Stebalien
Demote bitswap error to an info
72582c9 
Not being able to dial a peer we used to be connected to is interesting but
definitely not an error.

License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
@ghost ghost assigned Stebalien Dec 8, 2017
@ghost ghost added the status/in-progress In progress label Dec 8, 2017
@Stebalien
Copy link
Member Author

These are not the test failure's you're looking for (Jenkins is dead).

@whyrusleeping
Copy link
Member

@Stebalien idk, circle is angry too. what did you do?

@Stebalien
Copy link
Member Author 

expecting success: 
    kill -0 $IPFS_PID
  
ok 55 - 'ipfs daemon' is still running

expecting success: 
    test_kill_repeat_10_sec $IPFS_PID
  
not ok 56 - 'ipfs daemon' can be killed
#	
#	    test_kill_repeat_10_sec $IPFS_PID
#	  

# failed 1 among 56 test(s)
1..56
make: *** [test/sharness/t0271-filestore-utils.sh] Error 1

@whyrusleeping whyrusleeping merged commit 7fd7ab6 into master Dec 9, 2017
@whyrusleeping whyrusleeping deleted the fix/4470 branch December 9, 2017 17:57
@ghost ghost removed the status/in-progress In progress label Dec 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Stebalien Stebalien

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Stebalien @whyrusleeping