improve bitswap tests #4499
Merged
improve bitswap tests #4499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
License: MIT Signed-off-by: Steven Allen <steven@stebalien.com>
ConnectTo can be called concurrently from within bitswap. License: MIT Signed-off-by: Steven Allen <steven@stebalien.com>
ghost
assigned fixes #2444 License: MIT Signed-off-by: Steven Allen <steven@stebalien.com>
Stebalien
added
RFM
need/review
Stebalien
commented
Dec 16, 2017
| @@ -108,7 +108,7 @@ func TestLargeSwarm(t *testing.T) { | |||
| if detectrace.WithRace() { | |||
| // when running with the race detector, 500 instances launches | |||
| // well over 8k goroutines. This hits a race detector limit. | |||
| numInstances = 100 | |||
| numInstances = 75 | |||
There was a problem hiding this comment.
Max go routines with race detector: 8196.
Bitswap workers per peer: n^2.
75 means 75^2 = 5625
That gives us some healthy head-room for other random goroutines.
whyrusleeping
approved these changes
Dec 16, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In attempt to debug #4374 and #4108.
Also fixes #2444.