various ping fixes #4546
Merged
various ping fixes #4546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Stebalien
commented
Jan 4, 2018
Stebalien
commented
- Return an error when pinging self (an alternative would be to fake the ping). fixes ipfs ping self #4542.
- Better error messages.
- Return an error if the ping count is <= 0.
We don't allow dialing self for many (very good) reasons. fixes #4542 License: MIT Signed-off-by: Steven Allen <steven@stebalien.com>
License: MIT Signed-off-by: Steven Allen <steven@stebalien.com>
License: MIT Signed-off-by: Steven Allen <steven@stebalien.com>
License: MIT Signed-off-by: Steven Allen <steven@stebalien.com>
ghost
assigned
test/sharness/t0041-ping.sh
Outdated
| ' | ||
|
|
||
| test_expect_success "test ping other" ' | ||
| ipfsi 0 ping -n2 -- "$PEERID_1" && ipfsi 1 ping -n2 -- "$PEERID_0" |
There was a problem hiding this comment.
put each of these on its own line for readability
License: MIT Signed-off-by: Steven Allen <steven@stebalien.com>
|
@whyrusleeping picky picky... done. |
|
@Stebalien <3 <3 <3 <3 <3 <3 <3 |
whyrusleeping
approved these changes
Jan 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.