Extract: importers/chunk module as go-ipfs-chunker #4661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
hsanjuan
changed the title
|
@hsanjuan please preserve git history when possible (in go-ipfs-chunker). I know we have directions for how to do this somewhere but I can't find them (@whyrusleeping?). |
|
They are here: https://github.com/libp2p/go-libp2p#modularizing-go-libp2p |
License: MIT Signed-off-by: Hector Sanjuan <hector@protocol.ai>
License: MIT Signed-off-by: Hector Sanjuan <hector@protocol.ai>
License: MIT Signed-off-by: Hector Sanjuan <hector@protocol.ai>
License: MIT Signed-off-by: Hector Sanjuan <hector@protocol.ai>
License: MIT Signed-off-by: Hector Sanjuan <hector@protocol.ai>
License: MIT Signed-off-by: Hector Sanjuan <hector@protocol.ai>
hsanjuan
force-pushed
the
extract/chunk
branch
from
09bb75a
to
3819774
Compare
|
Thanks, that was useful. I have:
|
Stebalien
approved these changes
Feb 8, 2018
whyrusleeping
approved these changes
Feb 8, 2018
hacdias
pushed a commit
to ipfs/boxo
that referenced
this pull request
Jan 27, 2023
Extract: importers/chunk module as go-ipfs-chunker This commit was moved from ipfs/kubo@990e4df
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This extracts
chunkto https://github.com/ipfs/go-ipfs-chunkerThis is part of an effort to extract
importerfrom go-ipfs so they can be re-used by ipfs-cluster with more liberty (and without having to import go-ipfs itself).Before I leave everything ready to merge, is the naming
go-ipfs-chunkerok? It might be worth to go all the way and rename the whole thing and references togo-ipfs-splitter, or to rename theSplitterinterface toChunker.