Fix: sharness iptb connect timeout #4966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
License: MIT Signed-off-by: Łukasz Magiera <magik6k@gmail.com>
PlayerWithoutName
changed the title
Kubuxu
reviewed
Apr 23, 2018
| @@ -61,7 +61,7 @@ test_expect_success "start nodes" ' | |||
| ' | |||
|
|
|||
| test_expect_success "try connecting node in public network with priv networks" ' | |||
| iptb connect [1-4] 0 | |||
| iptb connect [1-4] 0 --timeout=2s | |||
There was a problem hiding this comment.
Can you put the option before the arguments? It is more natural that way.
License: MIT Signed-off-by: Kacper Łukawski <kacluk98@gmail.com>
PlayerWithoutName
force-pushed
the
fix/sharness-connect-timeout
branch
from
f89bfbf
to
2d9285d
Compare
Kubuxu
approved these changes
Apr 23, 2018
Kubuxu
added
RFM
and removed
need/author-input
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves the first point in #4961 by adding timeout to connect. Based on #4965.