Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract unixfs and importers to go-unixfs #5316

Merged
merged 2 commits into from
Jul 31, 2018
Merged

Extract unixfs and importers to go-unixfs #5316

merged 2 commits into from
Jul 31, 2018

Conversation

whyrusleeping
Copy link
Member

No description provided.

@whyrusleeping
move importers to unixfs directory
670c779 
License: MIT
Signed-off-by: Jeromy <jeromyj@gmail.com>
@ghost ghost assigned whyrusleeping Jul 30, 2018
@ghost ghost added the status/in-progress In progress label Jul 30, 2018
@whyrusleeping
Copy link
Member Author

This is the last one for now.

@whyrusleeping
extract go-unixfs (importers and unixfs)
b96a7a0 
License: MIT
Signed-off-by: Jeromy <jeromyj@gmail.com>
@whyrusleeping
Copy link
Member Author

@schomatis @Mr0grog I could use some help with the readme for go-unixfs: https://github.com/ipfs/go-unixfs

I started out with a directory explaining what each of the subpackages in it is for, but it would be great to expand that a bit, and maybe show a couple code examples.

@schomatis
Copy link
Contributor

I started out with a directory explaining what each of the subpackages in it is for, but it would be great to expand that a bit, and maybe show a couple code examples.

Yes, that's great! I'll get on it (I can take the lead on this one @Mr0grog, and ping you for a review later on).

This was referenced Jul 31, 2018
Closed
Closed
@whyrusleeping whyrusleeping merged commit 4bca53e into master Jul 31, 2018
@ghost ghost removed the status/in-progress In progress label Jul 31, 2018
@whyrusleeping whyrusleeping deleted the feat/extract-unixfs branch July 31, 2018 02:59
@schomatis
Copy link
Contributor

schomatis commented Jul 31, 2018 •
edited
Loading

I'm a bit lost, should the remaining unixfs directory here be ignored? I mean, should I move #5257 PR to go-unixfs, right?

(edit: #5319 will delete the unixfs dir)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Stebalien Stebalien Stebalien approved these changes

@Kubuxu Kubuxu Awaiting requested review from Kubuxu

Assignees

@whyrusleeping whyrusleeping

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@whyrusleeping @schomatis @Stebalien