commands/dht: use new cmds lib #5671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
overbool
force-pushed
the
refactor/commands/dht
branch
from
f3c98e2
to
514ecaf
Compare
magik6k
approved these changes
Oct 29, 2018
| Run: func(req cmds.Request, res cmds.Response) { | ||
| n, err := req.InvocContext().GetNode() | ||
| Run: func(req *cmds.Request, res cmds.ResponseEmitter, env cmds.Environment) error { | ||
| nd, err := cmdenv.GetNode(env) |
There was a problem hiding this comment.
@magik6k I just wanna write it in the same way in all core/commands/*.go
There was a problem hiding this comment.
Yeah, makes sense. (I thought that n was more common/conststently used, but checking now it's not and nd is used about as often, I have no preference, so this LGTM)
overbool
force-pushed
the
refactor/commands/dht
branch
from
514ecaf
to
138c196
Compare
License: MIT Signed-off-by: Overbool <overbool.xu@gmail.com>
License: MIT Signed-off-by: Overbool <overbool.xu@gmail.com>
Stebalien
force-pushed
the
refactor/commands/dht
branch
from
138c196
to
4a2c3cb
Compare
ghost
assigned 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refer: #5664
License: MIT
Signed-off-by: Overbool overbool.xu@gmail.com