cleanup the ping command #5680
Merged
cleanup the ping command #5680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
1. Use emit directly. 2. Abort immediately when the context is canceled (no need to wait a second for the sleep to elapse). 3. Ping once a second instead of once a second +TTL (to be more like ping) License: MIT Signed-off-by: Steven Allen <steven@stebalien.com>
We now *have* p2p multiaddrs. License: MIT Signed-off-by: Steven Allen <steven@stebalien.com>
Stebalien
force-pushed
the
fix/cleanup-ping
branch
from
1d74c40
to
b8f5355
Compare
Stebalien
commented
Oct 30, 2018
| if err != nil { | ||
| select { | ||
| case outChan <- &PingResult{Text: fmt.Sprintf("Peer lookup error: %s", err)}: | ||
| case <-ctx.Done(): |
There was a problem hiding this comment.
This should have used the command context, not the find-peer context. This context is pretty much guaranteed to be expired at this point (so will return "success" to the user when we fail to lookup the peer). This is causing the JS interop tests to fail (for good reason).
…in ping License: MIT Signed-off-by: Steven Allen <steven@stebalien.com>
magik6k
approved these changes
Oct 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
followup to the ping -> cmds 2.0 change