plugin: add a daemon plugin with access to the CoreAPI #5955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stebalien
force-pushed
the
feat/core-plugin
branch
from
7594d28
to
bb15ee1
Compare
ghost
assigned 
magik6k
approved these changes
Jan 29, 2019
Stebalien
force-pushed
the
feat/core-plugin
branch
from
bb15ee1
to
31dfe52
Compare
magik6k
reviewed
Jan 30, 2019
|
|
||
| (experimental) | ||
|
|
||
| Tracer plugins allow injecting an opentracing backend into go-ipfs. |
There was a problem hiding this comment.
Afaik there is a repo with this plugin somewhere, would be nice to have a link
There's no reason for these to be exclusive. License: MIT Signed-off-by: Steven Allen <steven@stebalien.com>
This allows users to run multiple go-ipfs "clients" in-process. License: MIT Signed-off-by: Steven Allen <steven@stebalien.com>
License: MIT Signed-off-by: Steven Allen <steven@stebalien.com>
License: MIT Signed-off-by: Steven Allen <steven@stebalien.com>
Stebalien
force-pushed
the
feat/core-plugin
branch
from
803d765
to
45734eb
Compare
fd
reviewed
Jun 11, 2019
| if err != nil { | ||
| closePlugins(loader.plugins[i:]) |
There was a problem hiding this comment.
I believe this is a bug. It should read loader.plugins[:i] as all plugins before i have been started not those after i.
There was a problem hiding this comment.
This seems to be the case, do you mind sending a PR?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #5954