Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve "name publish" ttl option documentation #5979

Merged
merged 2 commits into from
Feb 14, 2019

Conversation

AuHau
Copy link
Member

@AuHau AuHau commented Feb 9, 2019

Also refactoring DefaultRecordTTL to DefaultRecordEOL as it represents default value for lifetime and not ttl.

Copy link
Member

@Stebalien Stebalien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wording nits otherwise LGTM.

core/commands/name/publish.go Outdated Show resolved Hide resolved
License: MIT
Signed-off-by: Adam Uhlir <uhlir.a@gmail.com>
License: MIT
Signed-off-by: Adam Uhlir <uhlir.a@gmail.com>
@Stebalien Stebalien merged commit 402af03 into ipfs:master Feb 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants